Skip to content

Antalya 26.8 Backport of #124721 - Do not check Azure disks from the server config against remote_url_allow_hosts - #2905

Merged
zvonand merged 3 commits into
antalya-26.8from
backports/antalya-26.8/124721
Nov 20, 2026
Merged

zvonand merged 3 commits into
antalya-26.8from
backports/antalya-26.8/124721

Conversation

@blau-ai

@blau-ai blau-ai commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix server startup failure when an Azure Blob Storage disk from the server configuration has an endpoint that is not listed in remote_url_allow_hosts (since 26.7). Such disks are no longer checked against this list, like S3 disks, also when a data lake table uses one via SETTINGS disk = .... Disks created by disk(...) in a query, URLs of table functions and table engines, and redirects are still checked. An existing table on a disk(...) disk whose host is no longer allowed loads with a warning and keeps reading and writing to that host, as for S3 disks; a new disk(...) with that host is rejected. Closes ClickHouse#124431. (ClickHouse#124721 by @groeneai)

Documentation entry for user-facing changes

...

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • Aarch64 tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • CAS (content-addressed storage; Antalya only)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • OAuth (5m)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

PedroTadim and others added 2 commits November 18, 2026 16:07
…url-allow-hosts

Do not check Azure disks from the server config against remote_url_allow_hosts

Conflicts committed as-is; the next commit resolves them:
- src/Disks/DiskObjectStorage/ObjectStorages/ObjectStorageFactory.cpp (both modified)
- tests/integration/test_merge_tree_azure_blob_storage/test.py (both modified)
Kept the PR's Azure host check and test, and dropped the parts that depend on code antalya-26.8 doesn't have.
@blau-ai

blau-ai commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator Author

Port-AL: cherry-pick conflicts resolved by AI

Conflicted files:

  • src/Disks/DiskObjectStorage/ObjectStorages/ObjectStorageFactory.cpp (both modified)
  • tests/integration/test_merge_tree_azure_blob_storage/test.py (both modified)

Commits:

  • 8af433f: cherry-pick with the conflicts committed as-is

  • a46adaf: resolution

  • ObjectStorageFactory.cpp: the Azure creator now takes the named remote_host_filter_check parameter and runs the PR's host check on the connection URL, plus the ADLS Gen2 write host. A disk loaded from existing metadata only produces the warning.

  • ObjectStorageFactory.cpp: I kept the WriteBufferFromAzureDataLakeStorage.h include the check needs. I removed the getDiskConfigurationFromAST.h include that the conflict block carried, since the PR's own diff context still lists it but 26.8's HEAD side had already dropped it.

  • ObjectStorageFactory.cpp: I dropped the checkOrDropServerManagedCredentials block, because that method and its credential-restriction feature don't exist in antalya-26.8. The PR doesn't add it either.

  • test_merge_tree_azure_blob_storage/test.py: I kept the PR's test_endpoint_host_filter_on_restart. I dropped test_reject_zero_min_upload_part_size_in_disk_config, which was in the conflict block only because it isn't in this branch, and isn't part of the PR.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Workflow [PR], commit [0c29382]

@zvonand

zvonand commented Nov 20, 2026

Copy link
Copy Markdown
Member

@blau-ai

@blau-ai

blau-ai commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator Author

CI triage for 0c29382678c

Verdict: none of the 7 red checks comes from this PR.

Check What failed Cause From this PR?
Stateless (amd_binary, cas s3 storage, parallel)
Stateless (amd_asan_ubsan, cas s3 storage, parallel, 2/2)
03770_min_columns_to_activate_adaptive_write_buffer Pre-existing on antalya-26.8 No
Integration (amd_asan_ubsan, db disk, old analyzer, 3/8) test_s3_cluster/test.py::test_graceful_shutdown Pre-existing / flaky No
Stress test (amd_debug) Bad cast from type DB::ColumnVector<_BitInt(8)> to DB::ColumnVector<unsigned short> in max() Real bug, but in code this PR does not touch No (evidence below)
GrypeScanServer / Grype Scan Parse step timed out Infra No
Regression release swarms 1 module failed Pre-existing No
DCO Commits have no Signed-off-by Process No (code-wise)

1. 03770_min_columns_to_activate_adaptive_write_buffer (both CAS S3 stateless lanes)

Code: 241. DB::Exception: Query memory limit exceeded: would use 50.12 MiB (attempt to allocate chunk of 2.00 MiB), maximum: 50.00 MiB. (MEMORY_LIMIT_EXCEEDED)
(in query: insert into metric_log_1 select * from generateRandom() limit 1 settings max_memory_usage = '50Mi' ...)

2. test_s3_cluster/test.py::test_graceful_shutdown

File: test_s3_cluster/test.py:2171 - in test_graceful_shutdown
    assert errors == 0
E   assert 1 == 0

3. Stress test (amd_debug): Logical error: Bad cast from type A to B (STID: 1499-22cb)

Logical error: 'Bad cast from type DB::ColumnVector<_BitInt(8)> to DB::ColumnVector<unsigned short>'.
src/Common/assert_cast.h:43: assert_cast<DB::ColumnVector<unsigned short> const&, DB::IColumn const&>
src/AggregateFunctions/SingleValueData.cpp:208:5: DB::SingleValueDataFixed<unsigned short>::set(...)
src/AggregateFunctions/SingleValueData.cpp:357:9: DB::SingleValueDataFixed<unsigned short>::setIfGreater(...)
src/AggregateFunctions/AggregateFunctionsMinMax.cpp:66: AggregateFunctionMinMax<SingleValueDataFixed<unsigned short>, false>::add(...)

4. GrypeScanServer / Grype Scan

##[error]The action 'Parse grype results' has timed out after 60 minutes.
  • Classification: infra. The image scan itself found "0 high/critical vulnerabilities" (the Grype Scan altinityinfra/clickhouse-server:2905-… status). Only the result-parsing step hung, and it was killed by the 60-minute step limit. The -alpine server scan passed.
  • Next step: re-run the job.

5. Regression release swarms

6. DCO


Bottom line: CI shows no regression from this backport. The tests it adds or changes (test_allowed_url_from_config, test_merge_tree_azure_blob_storage, test_storage_iceberg_disks) do not appear among the failures. I'd re-run the Grype job and the db disk, old analyzer, 3/8 integration shard, and treat the remaining failures as known on antalya-26.8.

@zvonand
zvonand marked this pull request as ready for review November 20, 2026 13:28
@zvonand
zvonand merged commit 665bc5e into antalya-26.8 Nov 20, 2026
303 of 317 checks passed
@zvonand zvonand added the verified Approved for release label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants